Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the upload endpoint for PyPi #299

Closed
wants to merge 1 commit into from

Conversation

Keira-Crafts
Copy link
Contributor

I'm creating this PR because, as part of introducing GitHub Actions as a trusted publisher, we need to add the upload endpoint of PyPi to the pypi-release.yml workflow. That is what I do in this PR.

@w0rmr1d3r
Copy link
Member

Is this a duplicate of #295 ?

@Keira-Crafts
Copy link
Contributor Author

Is this a duplicate of #295 ?

Hi! No it is not. #295 lacked the upload endpoint, which is this line

@Keira-Crafts
Copy link
Contributor Author

This PR is not needed because we realised that publishing with the pypa/gh-action-pypi-publish@release/v1 workflow is needed as per the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants