Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actionability parameter to the rule baseclass. #243

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add actionability parameter to the rule baseclass. #243

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fc2ffe
Add actionability parameter to the rule baseclass.
Max-Huneshagen Nov 3, 2023
a6bf686
Merge branch 'master' into add-tag-for-actionability
jsoucheiron Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cfripper/rules/base_rules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@


class Rule(ABC):
ACTIONABILITY = True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rename the field to: ACTIONABLE instead of ACTIONABILITY
Since it'll be either actionable or non-actionable. Actionability sounds "weird"

Suggested change
ACTIONABILITY = True
ACTIONABLE = True

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to include the new property in the config or not?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure of it when I added my other comment. Now that I think of it, we can safe proof it, and add it to the config with the same value. This way, if some user/dependency of cfripper needs to override the value, it can be done safely in their config 👍

RULE_MODE = RuleMode.BLOCKING
RISK_VALUE = RuleRisk.MEDIUM
GRANULARITY = RuleGranularity.STACK
Expand Down
Loading