Upgrade to Duktape 2.5.0 #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyozi
commented
Jul 31, 2020
| pub const DUK_GIT_COMMIT: &'static [u8; 41usize] = b"6001888049cb42656f8649db020e804bcdeca6a7\0"; | ||
| pub const DUK_GIT_DESCRIBE: &'static [u8; 7usize] = b"v2.5.0\0"; | ||
| pub const DUK_GIT_BRANCH: &'static [u8; 7usize] = b"master\0"; | ||
| pub const DUK_USE_OS_STRING: &'static [u8; 4usize] = b"osx\0"; |
There was a problem hiding this comment.
It's funny that these (+ int MIN/MAX constants below) leak here, but I reckon it's not too harmful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I upgraded Duktape to 2.5.0 to see if it would fix a
SIGSEGV: invalid memory reference(spoiler: it didn't)But maybe Duktape can be upgraded anyway, unless there is some reason not to? I downloaded duktape-2.5.0.tar.xz from https://duktape.org/download.html and replaced existing files. All tests seem to pass ok.
I also added instructions for future Duktape upgrades and note about ffi-gen workaround I had to do to get it to compile on OS X.
Btw I didn't see anything too impactful in Duktape changelogs, but
Add "globalThis" binding, enabled by default. This replaces the previous "global" binding (which was disabled by default) to match the revised "global" specification.in 2.5 might be a breaking change? It could be disabled by default, although I would be happy to have it on by default.