Basic support for Ltac2 Backtrace / Ltac Profiling #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On bug_10107.v: - before this PR 0.037s - after this PR 0.043s - enable Ltac2 Backtrace 0.2s - enable Ltac Profiling 3s - without compiling 0.25s - Ltac2 Backtrace without compiling 1s - Ltac Profiling without compiling 30s Note that this implementation only puts the FrLtac frames, not the ones of anon functions. This is especially impactful for recursion as `Ltac2 rec bla binders := ...` becomes `Ltac2 bla binders := let rec bla binders := ... in bla binders` so only the top call gets a frame, and with profiling only the top call produces overhead. We should expect that adding frames for anonymous functions / recursive calls would be significantly worse than the current results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ie #8
On bug_10107.v:
Note that this implementation only puts the FrLtac frames, not the ones of anon functions.
This is especially impactful for recursion as
Ltac2 rec bla binders := ...becomesLtac2 bla binders := let rec bla binders := ... in bla bindersso only the top call gets a frame, and with profiling only the top call produces overhead.We should expect that adding frames for anonymous functions / recursive calls would be significantly worse than the current results.