Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Node.js 16 #223

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use Node.js 16 #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eef496b
package-lock.json - update for nodejs v16.20.2
MSP-Greg Jan 5, 2024
6358be9
Update Actions workflows and README.md
MSP-Greg Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/extension.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,11 @@ jobs:

strategy:
matrix:
# node-version: [10.4, 14.x, 16.x, 18.x]
node-version: [10.4]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
node-version: [16.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/previous-releases

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Setup variables
id: vars
Expand All @@ -44,7 +43,7 @@ jobs:
- run: ruby ./tools/package.rb ${{ steps.vars.outputs.sha_short }}

- name: Upload a Build Artifact
uses: actions/upload-artifact@v4.0.0
uses: actions/upload-artifact@v4
with:
name: Extension
path: archive/*.rbz
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,16 @@ jobs:
ruby-version: ['2.7', '3.2']

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby-version }}
bundler-cache: true # runs 'bundle install' and caches installed gems automatically

- name: RuboCop version information
run: bundle exec rubocop -V

- name: Run RuboCop
run: bundle exec rubocop
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ TestUp is a wrapper on top of the [minitest](https://github.com/seattlerb/minite

## Requirements

1. SketchUp 2017 or newer. (For SketchUp 2014-2016, use [TestUp 2.4](https://github.com/SketchUp/testup-2/releases/tag/2.4.2))
1. SketchUp 2017 or newer. (For SketchUp 2014 - 2016, use [TestUp 2.4](https://github.com/SketchUp/testup-2/releases/tag/2.4.2))

## Setup for Extension Developers

Easy: Download RBZ from the [Releases tab on GitHub](https://github.com/SketchUp/testup-2/releases).

Latest: Install TestUp from `git` source (See Setup for Contributing). Requires [Node](https://nodejs.org) to build webdialog content before 2.3+ versions can be used.
Latest: Install TestUp from `git` source (See Setup for Contributing). Requires [Node.js](https://nodejs.org) to build webdialog content before 2.3+ versions can be used.

Check out the [wiki](https://github.com/SketchUp/testup-2/wiki) for details on creating tests. Make sure to also refer to [minitest documentation](http://docs.seattlerb.org/minitest/).

Expand All @@ -22,7 +22,7 @@ Examples of extension projects implementing TestUp tests:

## Setup for Contributing/Running from Source

TestUp require [NodeJS](https://nodejs.org) to build webdialog resources: https://nodejs.org/en/ (Version 10.4 was used to build TestUp 2.3-2.5)
TestUp require [Node.js](https://nodejs.org) to build webdialog resources: https://nodejs.org/en/. Node.js 16.20.2 is used currently, Node.js 10.4 was used to build TestUp 2.3 - 2.5.

1. Fork the project to your own GitHub account. This is important so that we can do code review on changes done.
_Do **not** push directly to the main repository._
Expand Down
Loading