Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #5

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update README.md #5

wants to merge 4 commits into from

Conversation

dphdave
Copy link

@dphdave dphdave commented Nov 10, 2022

Make setup instructions a little more user-friendly!

Make setup instructions a little more user-friendly!
Add a warning when trying to load code that was pasted from the Ruby Console (hence has no source location)
@@ -6,6 +6,15 @@ This is a profiling tool for SketchUp Ruby extensions. It wraps [`Benchmark`](ht

![Profiling in SketchUp](docs/images/profiling.png)

## Installation
There is no RBZ file! Download the ZIP archive of the code from https://github.com/SketchUp/speedup/archive/refs/heads/main.zip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would encourage to clone the repo instead of downloading it.

Though, we should start adding RBZ files for each release.

@@ -39,7 +39,11 @@ def self.reload
random_profile_method = self.instance_methods.grep(/^profile_/).first
path = self.instance_method(random_profile_method).source_location.first
$VERBOSE = nil
load path
if File.exist?(path)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When would you run into this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants