Fixing Invisible Edges for Web Export #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mphe
reviewed
Nov 21, 2024
limbonaut
approved these changes
Nov 21, 2024
|
Looks good |
|
Looks good. |
mphe
approved these changes
Nov 21, 2024
Fix invisible edges issue for web export by processing index maps sequentially to avoid threading issues.
vanssnn
force-pushed
the
fix-invisble-edges-for-web-export
branch
from
95ebad5 to
b807137
Compare
|
Thanks, congratulations to your first merged PR! |
Thank you so much! I appreciate your guidance/support throughout the process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix invisible edges issue for web export by processing index maps sequentially to avoid threading issues (while it is probably slower than using thread).
Before:
(The edges (grass) is missing)
After:
