Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI / UX Changes #175

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

Pizzaandy
Copy link
Collaborator

Looking for feedback on this one, as there are some opinionated changes!
I'd like to add a setting for handle size in our own settings menu, but I don't know how 😎

  • Revamped visuals in Vertex Edit mode
    • Handles are now circles with a subtle outer shadow/gradient for contrast
    • Reduced opacity and removed stroke on shape outline
    • Added new icon to indicate bezier points
    • Use dashed lines when placing new vertices (holding alt)
    • Increase icon size and default grab radius (compared to editor default)
  • "H" bind temporarily hides UI
  • Vertex handles are hidden in Edit Vertex mode
  • Create Vertex mode defaults to adding between two points when the shape is closed (without needing to hold alt)
new-ui-demo.mp4

added "H" to hide UI keybind
revamp visuals for vert handles and edges
hide vert handles during edge edit mode
create vert mode now defaults to holding alt when the shape is closed
disable moving points in create vert mode
Copy link
Collaborator

@mphe mphe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only looked at the code and your video so far.
Code looks fine besides one nitpick.
Personally, I don't think the plugin needs a redesign, but I'm also not fully opposed, as it looks quite clean.
I still have to test the changes though and report back.

@@ -824,38 +826,40 @@ func draw_mode_edit_vert(overlay: Control, show_vert_handles: bool = true) -> vo
var t: Transform2D = get_et() * shape.get_global_transform()
var verts: PackedVector2Array = shape.get_vertices()
var points: PackedVector2Array = shape.get_tessellated_points()
draw_shape_outline(overlay, t, points, shape.modulate)
var color := Color(1, 1, 1, 0.6)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this color a constant to make it reusable and to prevent needless allocations.



func _draw_control_point_line(c: Control, vert: Vector2, cp: Vector2, tex: Texture2D) -> void:
# Draw the line with a dark and light color to be visible on all backgrounds
var color_dark := Color(0, 0, 0, 0.3)
var color_light := Color(1, 1, 1, .5)
var color_light := Color(1, 1, 1, .6)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the color constant from before.

@SirRamEsq
Copy link
Owner

This looks really nice, I really dig the new look.

Changes make sense to me, but I'm not a frequent enough user of the tool to know what the optimal work flow is.
I think my favorite change is "H" to hide the UI. Whatever the keybinding, I think hiding the UI would be a good feature. I'd often deselect the shape to try to get a look at it without the UI and a hotkey would have really optimized for me.

I think a handle size option for the verts is great idea. That's definitely a per-user preference.
I like the idea of hiding the vert handles in edge mode too, but I think that'd also be a user-preference thing.

Thanks for the hard work 🙂

@mphe
Copy link
Collaborator

mphe commented Oct 13, 2024

I finally did some testing, and I actually quite like the new visuals.
The changes to the create-vertex mode are great, the old behavior always bothered me.

There are still some things that I'd like to discuss:

  • I think the vertex handles in edge edit mode should still be visible to better differentiate between edges.
  • The vertex handles are a little too large. I like that they are larger than before, but now they are a little too large.
  • Vertices should still be movable in create mode for more flexibility.

@mphe
Copy link
Collaborator

mphe commented Nov 28, 2024

@Pizzaandy Are you still working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants