-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI / UX Changes #175
base: master
Are you sure you want to change the base?
UI / UX Changes #175
Conversation
added "H" to hide UI keybind revamp visuals for vert handles and edges hide vert handles during edge edit mode
create vert mode now defaults to holding alt when the shape is closed disable moving points in create vert mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only looked at the code and your video so far.
Code looks fine besides one nitpick.
Personally, I don't think the plugin needs a redesign, but I'm also not fully opposed, as it looks quite clean.
I still have to test the changes though and report back.
@@ -824,38 +826,40 @@ func draw_mode_edit_vert(overlay: Control, show_vert_handles: bool = true) -> vo | |||
var t: Transform2D = get_et() * shape.get_global_transform() | |||
var verts: PackedVector2Array = shape.get_vertices() | |||
var points: PackedVector2Array = shape.get_tessellated_points() | |||
draw_shape_outline(overlay, t, points, shape.modulate) | |||
var color := Color(1, 1, 1, 0.6) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this color a constant to make it reusable and to prevent needless allocations.
|
||
|
||
func _draw_control_point_line(c: Control, vert: Vector2, cp: Vector2, tex: Texture2D) -> void: | ||
# Draw the line with a dark and light color to be visible on all backgrounds | ||
var color_dark := Color(0, 0, 0, 0.3) | ||
var color_light := Color(1, 1, 1, .5) | ||
var color_light := Color(1, 1, 1, .6) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the color constant from before.
This looks really nice, I really dig the new look. Changes make sense to me, but I'm not a frequent enough user of the tool to know what the optimal work flow is. I think a handle size option for the verts is great idea. That's definitely a per-user preference. Thanks for the hard work 🙂 |
I finally did some testing, and I actually quite like the new visuals. There are still some things that I'd like to discuss:
|
@Pizzaandy Are you still working on this? |
Looking for feedback on this one, as there are some opinionated changes!
I'd like to add a setting for handle size in our own settings menu, but I don't know how 😎
new-ui-demo.mp4