added server debug information to double check the amount of workers #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potherca
requested changes
Sep 27, 2024
| @@ -33,6 +33,9 @@ async function main(options) { | |||
|
|
|||
| server.use(express.static(wwwroot)) | |||
|
|
|||
| console.log("Debug information:") | |||
There was a problem hiding this comment.
I am in favor of adding something to logging when the server starts, and I think this is a good start!1
To distinguish from development "logs", I would prefer if process.stdout were used.2
process.stdout.write(`"Debug information:"
maxworkers: ", maxWorkers
)Footnotes
-
@poef Is there any other information that is also relevant to output here? ↩
-
Maybe good to know,
console.logusesprocess(stdout or stderr, depending on use-case)` itself. ↩
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to make sure I had the correct amount set to maxWorkers in the options. Added some debug information in the console so it displays on server start.