Improves fallback code in Utf8String::extractWords() #8298
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deals with this:
SMF/Sources/Unicode/Utf8String.php
Lines 706 to 713 in 9aa2a6f
Specifically, this PR implements the default Unicode word break algorithm as fallback code for when the IntlBreakIterator class is unavailable. As noted in the Unicode documentation for this algorithm:
In other words, it is still best to use IntlBreakIterator if it is available, because it can adapt to the specific rules of a language, but the default is still a decent option for most languages most of the time.