Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some issues with caching.
First, there were some problems with the Sqlite cache API that have been fixed in 17f9186.
Second, and more importantly, 17fdb6e changes how we convert cached data to strings. Instead of using json_encode() and json_decode(), we are now using serialize() and unserialize(). This is necessary because in SMF 3.0 we need to cache objects. For example, when caching recent events, we pass a collection of SMF\Calendar\EventOccurrence objects to be cached. Encoding that to JSON loses data and the objects cannot be reconstructed when retrieved, resulting in nasty errors.