-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installer and upgrader rewrite #8093
base: release-3.0
Are you sure you want to change the base?
Installer and upgrader rewrite #8093
Conversation
5dba66b
to
2a8c9c9
Compare
A lot is incoming, it's my initial work I started to write the installer logic. You should be able to get through an install. But the base logic should get it going for an upgrader and converter logic. |
I've also added some task notes based on what I was thinking, please amend or adjust. |
Signed-off-by: Jon Stovell <[email protected]>
Signed-off-by: Jon Stovell <[email protected]>
Co-authored-by: John Rayes <[email protected]>
18e7abe
to
a8ef0db
Compare
Please remember not to force-push to a shared branch, @jdarwood007. I was able to reconcile the differences in my local repository fairly easily this time, but another time I might not be so lucky. |
Signed-off-by: Jon Stovell <[email protected]>
Co-authored-by: John Rayes <[email protected]>
Signed-off-by: Jon Stovell <[email protected]>
Signed-off-by: Jon Stovell <[email protected]>
Signed-off-by: Jon Stovell <[email protected]>
Signed-off-by: Jon Stovell <[email protected]>
Signed-off-by: Jon Stovell <[email protected]>
Signed-off-by: Jon Stovell <[email protected]>
Started work on Migration logic in upgrader. Minor fixes
# Conflicts: # Maintenance/Tools/Upgrade.php # other/install_3-0_MySQL.sql # other/install_3-0_PostgreSQL.sql
Finally got through the 2.1 upgrader sql logic. What a mess that was. I started on the migration logic itself. I also moved the Maintenance.php from Sources to the Maintenance folder. Had to fix some references for that. If we don't want it there, we can move it back. I also deleted the upgrade .SQL files for both 2.1 and 3.0. It will make a merge conflict if we make changes, but forces us to find and fix anything. I put the install.php in place. You can swap out install for the upgrade call to see it. I didn't want to overwrite upgrade.php until I have finished using it for referencing while building the migrations,cleanup and done steps to the upgrader. But I think having the install.php will let us fully test the installer to make sure we are happy with it and can cross that off the list. There is a note where I left off on the migration logic I am working on for the upgrade itself. I need to get back but wanted to get loaded what I have so far. |
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian Its being called in the Migration/v2_1/BoardDescriptions
What is the optimal call here to put the best effort that SMF can do to safely startup the User::$me object? Keeping in mind we may be coming from a env in which it may not be able to startup things. |
This seems to call ok. |
This would be better:
Also, is it indeed the intention here to load a guest user? Because that's what loading user 0 does. |
@jdarwood007, let's use this to work collaboratively on the installer/upgrader rewrite.
Fixes #8261