Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package version upgrades #686

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Package version upgrades #686

wants to merge 5 commits into from

Conversation

maaverik
Copy link
Collaborator

@maaverik maaverik commented Dec 31, 2021

npm install was failing for me on a new OS with higher node version (v16), so I thought I'd try to update packages to get it to install and fix vulnerabilities along the way. npm reported >100 vulnerabilities with existing versions.

This PR need not be merged unless we absolutely have to upgrade versions. It's only partially been tested, so bugs probably remain. I successfully updated most modules, and got the vulnerabilities reduced to 37. I had to uninstall the qr-scanner module, but it wasn’t working properly anyway, some console errors still remain, and eslint reports some false positive lint errors. I'll get back to fixing this sometime, but just documenting what I did here in case the same thing has to ever be done again someday.

Steps so far:

  1. Updated packages - https://nodejs.dev/learn/update-all-the-nodejs-dependencies-to-their-latest-version
    Removed react-qr-scanner package due to incompatibility with version of react-scripts
  2. Running dev server failed due to a gulp dependency error - fixed with https://stackoverflow.com/a/60921145/10281310
  3. Module not found error came up for react-refresh - fixed by changing versions of react-refresh-webpack-plugin as described in Module not found: Error: You attempted to import /node_modules/react-refresh/runtime.js which falls outside of the project src/ directory storybookjs/storybook#17049 and installing react-refresh package
  4. react-typeform-embed export not found - fixed by replacing existing component with Popup https://www.npmjs.com/package/react-typeform-embed - still work in progress to fix an error
  5. React-router v6 has different interfaces for routing - made changes according to https://stackoverflow.com/a/69849271/10281310, https://stackoverflow.com/questions/62861269/attempted-import-error-usehistory-is-not-exported-from-react-router-dom, https://stackoverflow.com/a/69796015/10281310
  6. babel-eslint not found in .eslintrc - replaced with @babel/eslint-parser
  7. eslint throwing errors in browser instead of warnings in console, fixed according to https://stackoverflow.com/a/64630234/10281310

To Do:

  1. Add a working qr scanner module
  2. Fix broken lint rules
  3. Fix console errors

@daltonfury42
Copy link
Collaborator

daltonfury42 commented Dec 31, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants