Firebase for Push notifications #685
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
daltonfury42
commented
Oct 26, 2021
•
daltonfury42
commented
- Move sentry/alerting to it's own file.
- Register to backend for notifications for token.
|
Preview URL for this branch is https://firebase.dpmhbfuiok7f8.amplifyapp.com. Please wait for sometime for the build to finish. |
maaverik
approved these changes
Nov 21, 2021
| import { useLinkDevice } from 'store/asyncActions'; | ||
|
|
||
| // Public key generated from firebase console | ||
| const vapidKey = |
There was a problem hiding this comment.
Just to clarify, it's okay to expose this key, right?
| @@ -11,7 +11,9 @@ const appSlice = createSlice({ | |||
| initialState: { | |||
| errorText: '', | |||
| infoText: '', | |||
| notificationPermission: null, // This state value is initialised by the notification service. | |||
| // This value is initilised at start by services/notification/system.js | |||
There was a problem hiding this comment.
Nit: typo for initialised
| */ | ||
| export const linkDevice = (deviceId) => ({ | ||
| method: 'put', | ||
| url: `/owner/link?deviceId=${deviceId}`, |
There was a problem hiding this comment.
I'm thinking this resource should be named something else. I feel that owner doesn't fit its purpose. Do you think /notifications/subscribe would fit?
There was a problem hiding this comment.
Another approach I can think of is simply a /notifications endpoint with body
{
subscribe: <BOOL>,
deviceId: <ID>
}
for PUT and PATCH.
|
|
||
| const registerForNotifications = () => { | ||
| getToken(messaging, { vapidKey }) | ||
| .then((deviceId) => { |
There was a problem hiding this comment.
So, is deviceId generated internally by firebase? Is it unique for every device?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.