-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some issues in the Bash engine #459
Conversation
Thanks! You had a great example in the issue, is it possible to add that to a small test case? Bash parsing is fairly nasty. The python support is much more slim, and easier to follow, but bash requires quite a lot of special cases. I had hopes of writing a proper parser, but with these changes (and some other), it's probably good enough as it is! And as for the coding style, I've started to change it in some files, so right now everything is in flux and your changes look good to me :-) |
I've dropped the commit which was supposed to fix coverage of multiline arrays. Indeed, it seems to be quiet difficult as trap 'echo ${LINENO}' DEBUG
declare -a array=( # <- this line
a
b
c
)
declare array=(
a
b
c
) # <- this line
declare array=(
a
b
c
) # <- this line |
See-also: SimonKagstrom#457 Signed-off-by: Mattéo Rossillol‑‑Laruelle <[email protected]>
See-also: SimonKagstrom#457 Signed-off-by: Mattéo Rossillol‑‑Laruelle <[email protected]>
With the last commit wich updates how subshells are parsed, the behavior (minor change) of kcov has changed; indeed, in order to skip the ')' for subshell functions, subshells, in general, does not have their ')' hit anymore. See-also: a750d47 See-also: SimonKagstrom#457 Signed-off-by: Mattéo Rossillol‑‑Laruelle <[email protected]>
See-also: a750d47 See-also: a03bf8d See-also: SimonKagstrom#457 Signed-off-by: Mattéo Rossillol‑‑Laruelle <[email protected]>
Merged, thanks a lot! |
This reverts commit 7baa1a5. Indeed, the changes added by this previous commit were due to a bug in kcov which is now fixed. See-also: SimonKagstrom/kcov#459 See-also: SimonKagstrom/kcov#457 Signed-off-by: Mattéo Rossillol‑‑Laruelle <[email protected]>
This pull request refers to this issue I reported some days ago.
It's not perfect but it should do the job in most of the cases.
I tried to respect your coding style. I hope I haven't made mistake and I'm waiting for review.
All tests passed.