Update Tinycrypt for mbedTLS 3.x support #243
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosahay-silabs
requested review from
jepenven-silabs,
jmartinez-silabs,
mkardous-silabs,
selissia,
lpbeliveau-silabs and
rcasallas-silabs
as code owners
* clean up * Add mld6 source file with include fix * Restyle Add mld6 source file to fix missing include (#215) * Restyled by whitespace * Restyled by clang-format * Restyled by prettier-markdown --------- Co-authored-by: Restyled.io <[email protected]> --------- Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <[email protected]>
rosahay-silabs
force-pushed
the
feature/update_tinycript
branch
from
7d6e143
to
dd32f62
Compare
| #include <stddef.h> | ||
| #include <stdint.h> | ||
|
|
||
| #if defined(SL_MBEDTLS_USE_TINYCRYPT) |
There was a problem hiding this comment.
Do we need this define guard since we are in a tinycript specific file?
Comment on lines
+13
to
+14
| // int mbedtls_platform_memmove(void *dst, const void *src, size_t num); | ||
| // int mbedtls_platform_memequal(const void *buf1, const void *buf2, size_t num); |
There was a problem hiding this comment.
Should these be commented / deleted?
| #include MBEDTLS_CONFIG_FILE | ||
| #endif | ||
|
|
||
| #if defined(SL_MBEDTLS_USE_TINYCRYPT) |
There was a problem hiding this comment.
what was changed in this file? Hard to tell from the diff
There was a problem hiding this comment.
where were these function taken from?
| @@ -12,6 +12,7 @@ | |||
| #define MBEDTLS_ASN1_WRITE_C | |||
| #define MBEDTLS_BASE64_C | |||
| #define MBEDTLS_CIPHER_C | |||
| #define MBEDTLS_CIPHER_PADDING_PKCS7 | |||
There was a problem hiding this comment.
can we revert this change since the define was already present?
| @@ -12,6 +12,7 @@ | |||
| #define MBEDTLS_ASN1_WRITE_C | |||
| #define MBEDTLS_BASE64_C | |||
| #define MBEDTLS_CIPHER_C | |||
| #define MBEDTLS_CIPHER_PADDING_PKCS7 | |||
There was a problem hiding this comment.
can we revert this change since the define was already present?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem / Feature
What is being fixed? What is the feature being added? Examples:
Change overview
Testing