Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add additional info for host metrics onboarding #6529

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Nov 25, 2024

Summary

Part of #5373

Helps in onboarding related changes


Important

Add functions to check host metrics and Kubernetes agent metrics in HostsRepo, update HostListResponse, and introduce GetCountOfThings() in ClickHouseReader.

  • Behavior:
    • Add DidSendHostMetricsData() and IsSendingK8SAgentMetrics() to HostsRepo in hosts.go to check for host metrics data and Kubernetes agent metrics.
    • Update GetHostList() in hosts.go to include results from the above functions in the response.
  • Functions:
    • Add GetCountOfThings() to ClickHouseReader in reader.go to count data entries for a given query.
  • Interfaces:
    • Add GetCountOfThings() to Reader interface in interface.go.
  • Constants:
    • Add SIGNOZ_TIMESERIES_V4_TABLENAME to constants.go.
  • Models:
    • Update HostListResponse in infra.go to include SentAnyHostMetricsData and IsSendingK8SAgentMetrics.

This description was created by Ellipsis for 7f2b22f. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 7f2b22f in 3 minutes and 18 seconds

More details
  • Looked at 151 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. pkg/query-service/app/clickhouseReader/reader.go:3389
  • Draft comment:
    Ensure the query string is sanitized or validated to prevent SQL injection vulnerabilities.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_KfXogSEVeXcWa3qr


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@srikanthccv srikanthccv merged commit 2e4956c into develop Nov 25, 2024
16 checks passed
@srikanthccv srikanthccv deleted the hosts-onboarding branch November 25, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants