docs: update JS examples to replace deprecated attributes & align angular examples #6390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗 |
|
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to a2d5d36 in 1 minute and 5 seconds
More details
- Looked at
2211lines of code in82files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/src/container/OnboardingContainer/Modules/APM/Javascript/md-docs/Angular/Docker/QuickStart/angular-docker-quickStart-instrumentApplication.md:28
- Draft comment:
Ensure that the removal ofSemanticResourceAttributes.SERVICE_VERSIONis intentional and aligns with the updated best practices for OpenTelemetry usage. This change is consistent across multiple files. - Reason this comment was not posted:
Confidence changes required:50%
The PR aims to replace deprecated attributes with updated ones. The change fromSemanticResourceAttributes.SERVICE_NAMEtoATTR_SERVICE_NAMEis consistent across the files. However, the removal ofSemanticResourceAttributes.SERVICE_VERSIONis not explained in the PR description, but it aligns with the goal of updating deprecated attributes. The changes are consistent and align with the intent of the PR.
Workflow ID: wflow_OdttCTxbHWMoHkeS
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Replace use of deprecated SemanticResourceAttributes.SERVICE_NAME by ATTR_SERVICE_NAME. Remove SemanticResourceAttributes.SERVICE_VERSION from Angular examples to align with other examples.
GauthierPLM
force-pushed
the
docs/js-examples-update
branch
from
a2d5d36
to
e1cacb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace the deprecated SemanticResourceAttributes.SERVICE_NAME with ATTR_SERVICE_NAME and remove SemanticResourceAttributes.SERVICE_VERSION from Angular examples to align them with other JS examples.
Important
Update JavaScript examples to replace deprecated attributes and align Angular examples with other JavaScript examples.
SemanticResourceAttributes.SERVICE_NAMEwithATTR_SERVICE_NAMEin Angular and Express examples.SemanticResourceAttributes.SERVICE_VERSIONfrom Angular examples.angular-docker-quickStart-instrumentApplication.md,angular-linuxamd64-quickStart-instrumentApplication.md, andexpress-docker-quickStart-instrumentApplication.md.This description was created by
for a2d5d36. It will automatically update as commits are pushed.