fix: disable autofill for time selection field

[Sachin-chaurasiya]

Summary

This PR adds autoComplete="off" to the time selection input in CustomTimePicker.tsx to prevent password managers from auto-filling values.

Also, added a unit test to ensure that the input element is rendered with the correct attribute.

Related Issues / PR's

Fixes #5875

Screenshots

Affected Areas and Manually Tested Areas

---

Important

Adds autoComplete="off" to CustomTimePicker input to prevent autofill and includes a test for this change.

• Behavior:
  • Adds autoComplete="off" to the time selection input in CustomTimePicker.tsx to prevent autofill by password managers.
• Testing:
  • Adds a unit test in CustomTimePicker.test.tsx to verify the autocomplete="off" attribute is present on the input element.

^{This description was created by for 4f93eb4. It will automatically update as commits are pushed.}

[welcome]

Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗

[CLAassistant]

All committers have signed the CLA.

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 4f93eb4 in 9 seconds

More details

• Looked at 69 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. frontend/src/components/CustomTimePicker/CustomTimePicker.test.tsx:49

• Draft comment:
  Consider adding a test case to verify that the 'autocomplete' attribute is not set to 'off' when it should not be. This will help ensure that the attribute is not accidentally removed in the future.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The test file is missing a test for the case when the input does not have the 'autocomplete' attribute set to 'off'. This would ensure that the attribute is not accidentally removed in the future.

Workflow ID: wflow_A4eiJ9fD7ybgL1Ai

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[Sachin-chaurasiya]

Hello @YounixM , Could you please review the PR? thanks

[vikrantgupta25]

Hi @Sachin-chaurasiya can you please add some before screenshot as well ? where the password manager was filling some value ?

[Sachin-chaurasiya]

Hi @Sachin-chaurasiya can you please add some before screenshot as well ? where the password manager was filling some value ?

Hey @vikrantgupta25, I have a password manager active; however, I'm unable to replicate the scenario where the password manager was filling in some value.

Screen.Recording.2024-11-05.at.12.52.12.PM.mov

[ChrisLightfootWild]

👋

I've encountered this myself locally (currently on version v0.54.0).

---

From a quick check, it only appeared to affect the time selector on the following pages:

• /logs/logs-explorer
• /traces-explorer

[makeavish]

This PR doesn't fix the issue. 1Password is still offering to autofill.
Tested on local