Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added vue example #77

Merged
merged 3 commits into from
Nov 1, 2020
Merged

Added vue example #77

merged 3 commits into from
Nov 1, 2020

Conversation

Metastasis
Copy link
Contributor

Description

Resolves "Vue sample" from #6

@codecov
Copy link

codecov bot commented Oct 28, 2020 •
edited
Loading

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #77   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines          391       391           
  Branches         5         5           
=========================================
  Hits           391       391

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcf0ee4...b946cc1. Read the comment docs.

Siemienik
Siemienik approved these changes Oct 30, 2020
View reviewed changes
Copy link
Owner

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:) Thank you for next greatness sample ^^

I have only one not important comment, if only isn't it a problem for you 😄

samples/vue/README.md Outdated Show resolved Hide resolved
@Siemienik Siemienik mentioned this pull request Oct 31, 2020
Open
9 tasks
Siemienik
Siemienik previously approved these changes Nov 1, 2020
View reviewed changes
Copy link
Owner

@Siemienik Siemienik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've tested it locally, works pretty good 😃

Siemienik
Siemienik approved these changes Nov 1, 2020
View reviewed changes
Copy link
Owner

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, everything what was ordered in #6 and #4 was done for Vue.

I appreciate keeping code out of indexes 👍

btw. It's first time that I reviewed Vue code - it looks really clear - nice 👍 I have to spent some time to recognise Vue deeply 🧐

@Siemienik Siemienik merged commit 3693c15 into Siemienik:master Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siemienik Siemienik Siemienik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Metastasis @Siemienik