Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Proxy to prevent modification of the original view model. #236

Merged
merged 5 commits into from
Nov 20, 2023

Conversation

Siemienik
Copy link
Owner

Fixes #137
Fixes #229

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b3befc9) 100.00% compared to head (803458f) 100.00%.

❗ Current head 803458f differs from pull request most recent head f98db5a. Consider uploading reports for the commit f98db5a to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #236   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        58    +2     
  Lines         1105      1126   +21     
  Branches       155       153    -2     
=========================================
+ Hits          1105      1126   +21     
Flag Coverage Δ
xlsx-import 100.00% <ø> (ø)
xlsx-renderer 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Siemienik Siemienik changed the title Using Proxy to prevent against modification the original view model. Using Proxy to prevent modification of the original view model. Nov 20, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Siemienik Siemienik merged commit 43c46b1 into master Nov 20, 2023
67 checks passed
@Siemienik Siemienik deleted the issue-229 branch November 20, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dates are output as strings in ISO format BUG: xlsx-renderer/Renderer mutate viewModel argument.
1 participant