cast to string, as Symbol is not predicted in that usecase

Siemienik · Nov 20, 2023 · d821a8b · d821a8b
1 parent 65c4f95
commit d821a8b
Showing 1 changed file with 3 additions and 9 deletions.
diff --git a/packages/xlsx-renderer/src/ViewModel.ts b/packages/xlsx-renderer/src/ViewModel.ts
@@ -5,16 +5,10 @@ export const createVmProxyHandler = ()=> {
 
     return {
         get(target: any, p: PropertyKey): any {
-            if (typeof p !== 'string' && typeof p !== 'number') {
-                return;
-            }
-            return p in data ? data[p] : target[p]
+            return p in data ? data[p as string] : target[p]
         },
-        set(target: unknown, p: PropertyKey, value: unknown): boolean {
-            if (typeof p !== 'string' && typeof p !== 'number') {
-                return false;
-            }
-            data[p] = value
+        set(target: any, p: PropertyKey, value: unknown): boolean {
+            data[p as string] = value
 
             return true
         },