#3 increase coverage & fix detected bug inside DeleteCell

Siemienik · Apr 19, 2020 · 62f536a · 62f536a
1 parent a3a878c
commit 62f536a
Show file tree

Hide file tree

Showing 7 changed files with 3 additions and 5 deletions.
diff --git a/src/cell/DeleteCell.ts b/src/cell/DeleteCell.ts
@@ -20,11 +20,9 @@ export class DeleteCell extends BaseCell {
             ?.toString()
             .split(' ')[2]; // todo make some function for scope.getCurrentTemplateValue()?.toString().split(' ')  ;
 
-        if (target === undefined) {
-            return this;
-        } // it's ok here
-
-        scope.vm[target] = undefined;
+        if (target !== undefined) {
+            scope.vm[target] = undefined;
+        }
 
         scope.setCurrentOutputValue(null);
         scope.incrementCol();

diff --git a/tests/integration/data/Renderer003-WsName/expected.xlsx b/tests/integration/data/Renderer003-WsName/expected.xlsx
diff --git a/tests/integration/data/Renderer003-WsName/template.xlsx b/tests/integration/data/Renderer003-WsName/template.xlsx
diff --git a/tests/integration/data/Renderer008-Delete/template.xlsx b/tests/integration/data/Renderer008-Delete/template.xlsx
diff --git a/...Renderer010-ForEach-Formula/expected.xlsx → ...on/data/Renderer010-Formula/expected.xlsx b/...Renderer010-ForEach-Formula/expected.xlsx → ...on/data/Renderer010-Formula/expected.xlsx
diff --git a/...Renderer010-ForEach-Formula/template.xlsx → ...on/data/Renderer010-Formula/template.xlsx b/...Renderer010-ForEach-Formula/template.xlsx → ...on/data/Renderer010-Formula/template.xlsx
diff --git a/...enderer010-ForEach-Formula/viewModel.json → ...n/data/Renderer010-Formula/viewModel.json b/...enderer010-ForEach-Formula/viewModel.json → ...n/data/Renderer010-Formula/viewModel.json