On branch ratingFix/Darkice000 #167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your branch is up to date with 'origin/ratingFix/Darkice000'. Changes to be committed: modified: core/models.py modified: core/views.py modified: templates/components/news.html Fixes: 1. style attribute in news.html,type error. 2. Rating overflows after some long decimal places number encounters 3. Rating does not appearing from database for the user if he rated previously, but not showing when reloging. If he rate then shows but when relogin all disappears. Not Fixed: 1. Rating button still not showing in green after being rated.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Awesome work, @DarkIce000! 🎉 Thank you for your contribution and efforts to enhance NEWS-AGGREGATOR-PROJECT ! We will review your changes soon and provide feedback.
|
@SiddharthBahuguna Please see if it is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to be committed:
modified: core/views.py
modified: templates/components/news.html
Fixes:
Not Fixed:
Related Issue
Rating does not appearing from database for the user if he rated previously, but not showing when reloging. If he rate then shows but when relogin all disappears.
Type of PR
Checklist: