Skip to content

Commit

Permalink
Merge pull request #67 from rromanchuk/patch-1
Browse files Browse the repository at this point in the history
  • Loading branch information
jdouglas-nz authored Aug 9, 2021
2 parents 9dbf41d + 5cec7a7 commit ff089f0
Showing 1 changed file with 11 additions and 3 deletions.
14 changes: 11 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,20 @@ To make your scheme shared go to "Manage schemes" in Xcode and tick "Shared" che
### what is this `plist_build_setting_support` stuff about?!
If you have a xcodeproject and have updated to Xcode 11, you'll notice that if you change your build and version numbers through the UI, the actual numbers are now stored inside build settings inside build confiugration. The Info.plist file -- where they used to be stored -- now contains build setting variables (looks like `$(CURRENT_PROJECT_VERSION)` or `$(MARKETING_VERSION)`, for build number and version number respectively).
If you are at this migration 'turning point', you have two options. you can either:
1. simply add `plist_build_setting_support: true` to your plist action parameters
2. change the command to be the xcodeproj variants - i.e. `increment_version_number_in_xcodeproj` or `increment_build_number_in_xcodeproj`

these also apply to the `getters` of build and version numbers.
- Continue using the legacy method of inserting build and versions directly into plists by simply add `plist_build_setting_support: true` to your plist action parameters

OR

- Change the command to be the xcodeproj variants - i.e. `increment_version_number_in_xcodeproj` or `increment_build_number_in_xcodeproj` these also apply to the `getters` of build and version numbers.

##### Warning for those migrating
Verify your plist files are using the build variables (new) `$(CURRENT_PROJECT_VERSION)` or `$(MARKETING_VERSION)`. You can force this migration by simply modifying Version/Build fields for each one of your targets in UI. If you forget to make this change, or something else is writing and replacing it, xcodeproj actions will successfully update, but your build will have no reference to those values essentially becoming NOOP

We will leave the plist actions in, as for those consumers who are limited to their upgrade path.



## Actions

### increment_version_number_in_plist
Expand Down

0 comments on commit ff089f0

Please sign in to comment.