Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(hostd): adjust resize volume validation, add test #755

Merged

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Sep 26, 2024

Small PR to add a missing test, no change in functionality.

  • Add a test for resizing a volume.
  • Adjust validation to use BigNumber operations.

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hostd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 8:19pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 8:19pm
explorer-zen ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 8:19pm
renterd ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 8:19pm
website ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 8:19pm

Copy link

changeset-bot bot commented Sep 26, 2024

⚠️ No Changeset found

Latest commit: 370d8be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alexfreska and the rest of your teammates on Graphite Graphite

@alexfreska alexfreska merged commit 3f5745a into main Sep 27, 2024
33 checks passed
@alexfreska alexfreska deleted the refactor_hostd_adjust_resize_volume_validation_add_test branch September 27, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants