fix(renterd): network average prices #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alexfreska
commented
Sep 26, 2024
•
alexfreska
commented
- Fixed a bug where the network average prices would show as 0 in the configuration fields.
- Max RPC price and max contract price now show a suggestion instead of a network average (10/million SC and 1 SC).
- The network averages were showing as near 0 values, which could direct the user to set them too low.
- Added handful of tests related to averages and fiat conversion.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
🦋 Changeset detectedLatest commit: fa06b50 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alexfreska and the rest of your teammates on |
This was referenced Sep 26, 2024
alexfreska
force-pushed
the
fix_renterd_network_average_prices
branch
from
652a098 to
63e470d
Compare
alexfreska
force-pushed
the
refactor_renterd_typescript_strict_mode_for_config_feature
branch
from
915920a to
a78cc78
Compare
alexfreska
force-pushed
the
fix_renterd_network_average_prices
branch
from
63e470d to
959208d
Compare
peterjan
reviewed
Sep 27, 2024
alexfreska
force-pushed
the
fix_renterd_network_average_prices
branch
from
959208d to
47be044
Compare
alexfreska
force-pushed
the
refactor_renterd_typescript_strict_mode_for_config_feature
branch
from
a78cc78 to
2d66210
Compare
alexfreska
force-pushed
the
fix_renterd_network_average_prices
branch
from
47be044 to
b95be11
Compare
peterjan
approved these changes
Sep 30, 2024
alexfreska
changed the base branch from
refactor_renterd_typescript_strict_mode_for_config_feature
to
graphite-base/754
alexfreska
force-pushed
the
graphite-base/754
branch
from
2d66210 to
9a99d95
Compare
alexfreska
force-pushed
the
fix_renterd_network_average_prices
branch
from
b95be11 to
6f14dab
Compare
alexfreska
force-pushed
the
fix_renterd_network_average_prices
branch
from
6f14dab to
d04f79a
Compare
alexfreska
force-pushed
the
fix_renterd_network_average_prices
branch
from
d04f79a to
8a62947
Compare
alexfreska
force-pushed
the
fix_renterd_network_average_prices
branch
from
8a62947 to
99c662c
Compare
alexfreska
force-pushed
the
fix_renterd_network_average_prices
branch
from
99c662c to
fa06b50
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.