Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(renterd): settings APIs and daemon explorer exchange rates #741

Conversation

alexfreska
Copy link
Member

  • Removed deprecated setting APIs.
  • Added new strong settings APIs.
  • The configuration feature now interally uses the new strong settings API.
  • The configuration feature no longer includes the enabled pinning or forex endpoint options under price pinning.
  • The app now uses the daemon configured explorer for exchange rates.
  • The keys feature now interally uses the updated S3 settings API.
  • The bus state API now includes daemon configured explorer.

Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
renterd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 3:05pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 3:05pm
explorer-zen ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 3:05pm
hostd ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 3:05pm
website ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 3:05pm

Copy link

changeset-bot bot commented Sep 13, 2024

🦋 Changeset detected

Latest commit: 1b493aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@siafoundation/renterd-js Minor
@siafoundation/renterd-react Minor
@siafoundation/renterd-types Minor
renterd Minor
@siafoundation/clusterd Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexfreska alexfreska force-pushed the refactor_renterd_gouging_base_units branch from 5434404 to 6785a19 Compare September 13, 2024 20:02
@alexfreska alexfreska force-pushed the refactor_renterd_settings_apis_and_daemon_explorer_exchange_rates branch from 430a0b6 to 8b3e032 Compare September 13, 2024 20:02
@alexfreska alexfreska force-pushed the refactor_renterd_gouging_base_units branch from 6785a19 to 1b6b640 Compare September 13, 2024 20:14
@alexfreska alexfreska force-pushed the refactor_renterd_settings_apis_and_daemon_explorer_exchange_rates branch from 8b3e032 to 4172b33 Compare September 13, 2024 20:14
@alexfreska alexfreska force-pushed the refactor_renterd_gouging_base_units branch from 1b6b640 to 0f88698 Compare September 13, 2024 20:27
@alexfreska alexfreska force-pushed the refactor_renterd_settings_apis_and_daemon_explorer_exchange_rates branch from 4172b33 to 89c7094 Compare September 13, 2024 20:27
@alexfreska alexfreska force-pushed the refactor_renterd_gouging_base_units branch from 0f88698 to 6460bb2 Compare September 16, 2024 17:44
@alexfreska alexfreska force-pushed the refactor_renterd_settings_apis_and_daemon_explorer_exchange_rates branch from 89c7094 to e71f3b5 Compare September 16, 2024 17:44
Copy link
Member

@peterjan peterjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left two minor comments but def. looks good overall 👍

@alexfreska alexfreska force-pushed the refactor_renterd_gouging_base_units branch from 6460bb2 to 973438a Compare September 17, 2024 12:16
@alexfreska alexfreska force-pushed the refactor_renterd_settings_apis_and_daemon_explorer_exchange_rates branch from e71f3b5 to cd851a9 Compare September 17, 2024 12:16
@alexfreska alexfreska force-pushed the refactor_renterd_gouging_base_units branch from 973438a to 4159e8a Compare September 17, 2024 12:23
@alexfreska alexfreska force-pushed the refactor_renterd_settings_apis_and_daemon_explorer_exchange_rates branch from cd851a9 to d7a086a Compare September 17, 2024 12:23
@alexfreska alexfreska force-pushed the refactor_renterd_settings_apis_and_daemon_explorer_exchange_rates branch from d7a086a to 2cf5b66 Compare September 17, 2024 13:52
Copy link
Member Author

alexfreska commented Sep 17, 2024

Merge activity

  • Sep 17, 10:13 AM EDT: @alexfreska started a stack merge that includes this pull request via Graphite.
  • Sep 17, 10:32 AM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 17, 10:33 AM EDT: @alexfreska merged this pull request with Graphite.

@alexfreska alexfreska changed the base branch from refactor_renterd_gouging_base_units to graphite-base/741 September 17, 2024 14:27
@alexfreska alexfreska changed the base branch from graphite-base/741 to main September 17, 2024 14:30
@alexfreska alexfreska force-pushed the refactor_renterd_settings_apis_and_daemon_explorer_exchange_rates branch from 2cf5b66 to 1b493aa Compare September 17, 2024 14:31
@alexfreska alexfreska merged commit ac703a9 into main Sep 17, 2024
10 of 29 checks passed
@alexfreska alexfreska deleted the refactor_renterd_settings_apis_and_daemon_explorer_exchange_rates branch September 17, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants