-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add explored api sdk to config, for use in future siacentral phase out #698
Conversation
🦋 Changeset detectedLatest commit: a6b54cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
@telestrial its not a Docker config, its during the Nx build. The config/index.ts file is swapped with config/testnet-zen.ts using an Nx file replacement during the NX build process. You can see this in the build targets: web/apps/explorer/project.json Lines 37 to 44 in cf99504
|
40af084
to
0c141db
Compare
c8b4cf3
to
6258e3b
Compare
6258e3b
to
77ce818
Compare
77ce818
to
a6b54cd
Compare
I figured this one conceptually made sense as its own little PR as opposed to tacking it onto the first phase out route PR and having it get lost in the history a bit.
The zen address is probably wrong here or there just isn't support for this yet. Should I remove that line or is there a current working address? Am I correct that we're using testnet-zen in a docker config to stand in for that local
index.ts
to switch between the different modes?