Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add explored api sdk to config, for use in future siacentral phase out #698

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

telestrial
Copy link
Contributor

I figured this one conceptually made sense as its own little PR as opposed to tacking it onto the first phase out route PR and having it get lost in the history a bit.

The zen address is probably wrong here or there just isn't support for this yet. Should I remove that line or is there a current working address? Am I correct that we're using testnet-zen in a docker config to stand in for that local index.ts to switch between the different modes?

Copy link

changeset-bot bot commented Aug 26, 2024

🦋 Changeset detected

Latest commit: a6b54cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
explorer Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Aug 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2024 9:27pm
explorer-zen ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2024 9:27pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
hostd ⬜️ Ignored (Inspect) Visit Preview Aug 26, 2024 9:27pm
renterd ⬜️ Ignored (Inspect) Visit Preview Aug 26, 2024 9:27pm
website ⬜️ Ignored (Inspect) Visit Preview Aug 26, 2024 9:27pm

apps/explorer/config/index.ts Outdated Show resolved Hide resolved
apps/explorer/config/testnet-zen.ts Outdated Show resolved Hide resolved
@alexfreska
Copy link
Member

alexfreska commented Aug 26, 2024

Am I correct that we're using testnet-zen in a docker config to stand in for that local index.ts to switch between the different modes?

@telestrial its not a Docker config, its during the Nx build. The config/index.ts file is swapped with config/testnet-zen.ts using an Nx file replacement during the NX build process. You can see this in the build targets:

"production-testnet-zen": {
"outputPath": "dist/apps/explorer-testnet-zen",
"fileReplacements": [
{
"replace": "apps/explorer/config/index.ts",
"with": "apps/explorer/config/testnet-zen.ts"
}
]

@telestrial telestrial force-pushed the explorer-explored-sdk branch from 77ce818 to a6b54cd Compare August 26, 2024 21:10
@alexfreska alexfreska self-requested a review August 26, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants