Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: react-core docs, cleanup #681

Merged
merged 1 commit into from
Aug 14, 2024
Merged

refactor: react-core docs, cleanup #681

merged 1 commit into from
Aug 14, 2024

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Aug 13, 2024

  • Added some documentation to react-core.
  • Noticed and refactored the following:
    • App setting allowCustomApi is now more accurately named loginWithCustomApi.
    • The network block height calculation methods have been moved to the units
      package.

Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 2:47pm
explorer-zen ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 2:47pm
hostd ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 2:47pm
renterd ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 2:47pm
walletd ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 2:47pm
website ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 2:47pm

Copy link

changeset-bot bot commented Aug 13, 2024

🦋 Changeset detected

Latest commit: 4b9960b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@siafoundation/design-system Minor
@siafoundation/react-core Minor
@siafoundation/hostd-react Minor
@siafoundation/renterd-react Minor
@siafoundation/units Minor
@siafoundation/walletd-react Minor
@siafoundation/walletd-mock Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member Author

alexfreska commented Aug 13, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alexfreska and the rest of your teammates on Graphite Graphite

Base automatically changed from chore_prettier to main August 13, 2024 18:43
@alexfreska alexfreska force-pushed the refactor_react-core branch from f13c330 to 7a4ce15 Compare August 13, 2024 18:52
@alexfreska alexfreska requested a review from telestrial August 13, 2024 18:53
@alexfreska alexfreska force-pushed the refactor_react-core branch from 7a4ce15 to e1a7a23 Compare August 13, 2024 18:54
Copy link
Contributor

@telestrial telestrial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I appreciate the information.

@alexfreska alexfreska force-pushed the refactor_react-core branch from e1a7a23 to 4b9960b Compare August 14, 2024 14:31
@alexfreska alexfreska merged commit a6c956e into main Aug 14, 2024
18 of 19 checks passed
@alexfreska alexfreska deleted the refactor_react-core branch August 14, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants