Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle parameter routes in nextjs router #537

Merged
merged 2 commits into from
Mar 22, 2024
Merged

fix: handle parameter routes in nextjs router #537

merged 2 commits into from
Mar 22, 2024

Conversation

n8maninger
Copy link
Member

@n8maninger n8maninger requested a review from alexfreska March 22, 2024 04:30
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 220e7d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@n8maninger n8maninger force-pushed the nate/fix-nextjs-router branch from 7c3ab59 to 220e7d2 Compare March 22, 2024 07:12
alexfreska
alexfreska approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@alexfreska alexfreska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🦾

@alexfreska alexfreska merged commit 3ffeded into main Mar 22, 2024
1 check passed
@alexfreska alexfreska deleted the nate/fix-nextjs-router branch March 22, 2024 12:29
@alexfreska alexfreska mentioned this pull request Mar 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfreska alexfreska alexfreska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui: refreshing page inside a bucket causes 404
2 participants
@n8maninger @alexfreska