Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix humanUnits for hostd using 1e7 for millions #466

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

iuri-gg
Copy link
Contributor

@iuri-gg iuri-gg commented Jan 15, 2024

hostd settings is showing incorrect number for base rpc price and Sector access price. It's off by 10 due to using 1e7 instead of 1e6 for calculating millions

Copy link

changeset-bot bot commented Jan 15, 2024

🦋 Changeset detected

Latest commit: 3043df5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
hostd Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexfreska
Copy link
Member

alexfreska commented Jan 15, 2024

@iuri-gg hey thank you so much for finding this bug and your contribution!

The repo follows conventional commits, please prefix your commit with fix:.

Also, could you add a changeset so that your fix shows up in the next version's change log?

Locally run npx changeset select hostd, select patch change, and then add a description such as:

Fixed an issue where the base RPC and sector access price calculation was off by 10.

and then add the file to this commit.

@alexfreska
Copy link
Member

@iuri-gg also while you are in this file, could you fix the comment, it says PRC instead of RPC 😄

@iuri-gg
Copy link
Contributor Author

iuri-gg commented Jan 15, 2024

@alexfreska Thanks for the feedback. Hope I got it correctly this time 🤞

@alexfreska
Copy link
Member

@alexfreska Thanks for the feedback. Hope I got it correctly this time 🤞

@iuri-gg thats perfect. I will run the CI and double check the values.

@alexfreska
Copy link
Member

alexfreska commented Jan 15, 2024

@iuri-gg looks like you need to update a few tests - they are currently checking for the incorrect values.
https://github.com/SiaFoundation/web/actions/runs/7533680654/job/20506787267?pr=466#step:7:124
Screenshot 2024-01-15 at 12 32 54 PM

To run the hostd tests:

nx test hostd

@iuri-gg
Copy link
Contributor Author

iuri-gg commented Jan 15, 2024

dont know why package-lock.json got updated. is that expected? if I run npm install, it updates the package-lock.json

@alexfreska
Copy link
Member

dont know why package-lock.json got updated. is that expected? if I run npm install, it updates the package-lock.json

yeah thats good, a previous PR likely missed an update

@alexfreska
Copy link
Member

@iuri-gg merging, thank you! 🚀 Your change will show up in the release PR shortly: #465

Note: The CI failed because the package-lock change triggered a build across all projects, and external contributors do not have permission to build the website, which is the only project that failed, everything else passed!

@alexfreska alexfreska merged commit 2300865 into SiaFoundation:main Jan 16, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants