-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix humanUnits for hostd using 1e7 for millions #466
Conversation
🦋 Changeset detectedLatest commit: 3043df5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@iuri-gg hey thank you so much for finding this bug and your contribution! The repo follows conventional commits, please prefix your commit with Also, could you add a changeset so that your fix shows up in the next version's change log? Locally run
and then add the file to this commit. |
@iuri-gg also while you are in this file, could you fix the comment, it says PRC instead of RPC 😄 |
@alexfreska Thanks for the feedback. Hope I got it correctly this time 🤞 |
@iuri-gg thats perfect. I will run the CI and double check the values. |
@iuri-gg looks like you need to update a few tests - they are currently checking for the incorrect values. To run the
|
dont know why |
yeah thats good, a previous PR likely missed an update |
@iuri-gg merging, thank you! 🚀 Your change will show up in the release PR shortly: #465 Note: The CI failed because the package-lock change triggered a build across all projects, and external contributors do not have permission to build the website, which is the only project that failed, everything else passed! |
hostd settings is showing incorrect number for base rpc price and Sector access price. It's off by 10 due to using 1e7 instead of 1e6 for calculating millions