fix: use total count to check if there's enough contracts #421
Conversation
🦋 Changeset detectedLatest commit: 382fa43 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -3,7 +3,8 @@ import { useRedundancySettings } from '../../../hooks/useRedundancySettings' | |||
|
|
|||
| export function useNotEnoughContracts() { | |||
| const redundancy = useRedundancySettings() | |||
| const { datasetCount, isLoading: isContractsLoading } = useContracts() | |||
| const { dataset, isLoading: isContractsLoading } = useContracts() | |||
There was a problem hiding this comment.
Im unsure if it's better to it this way or change datasetCount in useContracts() to use the unfiltered dataset, and another variable for pagination called datasetFiltererdCount and update that code as well.
There was a problem hiding this comment.
Hey, thanks so much for the PR! I think it would be clearest to have datasetCount and datasetFilteredCount (and pageCount).
There was a problem hiding this comment.
Alright, I've given that a try as well!
There was a problem hiding this comment.
@multikatt perfect, could you add a changeset so that the bug fix is included in the release notes.
npx changeset
Use the arrow keys and hit spacebar to select renterd, skip major and minor version with enter key to select patch version bump. Enter a message like:
Fixed an issue where the filtered contract count was being used in the onboarding checks.
And then commit the generated file to this PR, it should be .changesets/some-strange-name.md
There was a problem hiding this comment.
@multikatt looks great! The CI will probably fail because the second two commits are not formatted as conventional commits, maybe squash them into the first commit and force push, after that we are good to merge!
|
Hope I did that right 😃 |
|
Thank you so much! 🚀 |
datasetCount from useContracts() is using the filtered count which makes the onboarding panel appear.
Related to SiaFoundation/renterd#765