fix: renterd max rpc price rounding

SiaFoundation · Mar 21, 2024 · 105c46b · 105c46b
1 parent 3a1b3d4
commit 105c46b
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/.changeset/dry-ligers-melt.md b/.changeset/dry-ligers-melt.md
@@ -0,0 +1,5 @@
+---
+'renterd': patch
+---
+
+Fixed an issue where the max RPC price configuration would round decimal values to 0. Closes https://github.com/SiaFoundation/renterd/issues/1050
diff --git a/apps/renterd/contexts/config/transform.spec.ts b/apps/renterd/contexts/config/transform.spec.ts
@@ -408,14 +408,18 @@ describe('tansforms', () => {
         },
         contractSet,
         uploadPacking,
-        gouging,
+        gouging: {
+          ...gouging,
+          maxRPCPrice: '100000000000000000',
+        },
         redundancy,
       })
       expect(settings.downloadTBMonth).toEqual(new BigNumber('92.72'))
       // a little different due to rounding
       expect(
         transformUpAutopilot('Mainnet', settings, autopilot).contracts.download
       ).toEqual(91088814814815)
+      expect(settings.maxRpcPriceMillion).toEqual(new BigNumber('0.1'))
 
       settings = transformDown({
         hasBeenConfigured: true,

diff --git a/apps/renterd/contexts/config/transform.ts b/apps/renterd/contexts/config/transform.ts
@@ -261,6 +261,7 @@ export function transformDownGouging({
     averages,
     hasBeenConfigured,
   })
+
   return {
     maxStoragePriceTBMonth: toSiacoins(
       new BigNumber(gouging.maxStoragePrice) // bytes/block
@@ -274,8 +275,9 @@ export function transformDownGouging({
     ),
     maxDownloadPriceTB: toSiacoins(gouging.maxDownloadPrice, scDecimalPlaces),
     maxContractPrice: toSiacoins(gouging.maxContractPrice, scDecimalPlaces),
-    maxRpcPriceMillion: toSiacoins(gouging.maxRPCPrice, scDecimalPlaces).times(
-      1_000_000
+    maxRpcPriceMillion: toSiacoins(
+      new BigNumber(gouging.maxRPCPrice).times(1_000_000),
+      scDecimalPlaces
     ),
     hostBlockHeightLeeway: new BigNumber(gouging.hostBlockHeightLeeway),
     minPriceTableValidityMinutes: new BigNumber(