Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accumulate churn information into single alert instead of registering multiple #989

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

ChrisSchinnerl
Copy link
Member

@ChrisSchinnerl ChrisSchinnerl commented Feb 21, 2024

This is done by introducing an accumulator which is reset every time the alert was dismissed by the user.

Depends on #987

@ChrisSchinnerl ChrisSchinnerl self-assigned this Feb 21, 2024
@ChrisSchinnerl ChrisSchinnerl force-pushed the chris/churn-alert-accumulator branch from 0747df9 to 77e0fd0 Compare February 21, 2024 12:36
@ChrisSchinnerl ChrisSchinnerl marked this pull request as ready for review February 22, 2024 08:47
Copy link
Member

@peterjan peterjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The churn accumulator is a neat idea, that said I personally still prefer alerts that auto-expire to keep the total number of alerts somewhat in check. By accumulating additions and removals over time you lose some key information like contracts flip-flopping in and out of the set as well as bursts of churn that might coincide with other events. Don't mind though, definitely an improvement 👍

@ChrisSchinnerl ChrisSchinnerl force-pushed the chris/churn-alert-accumulator branch from 77e0fd0 to c17252a Compare February 23, 2024 12:15
@ChrisSchinnerl ChrisSchinnerl merged commit 3f09191 into dev Feb 23, 2024
8 checks passed
@ChrisSchinnerl ChrisSchinnerl deleted the chris/churn-alert-accumulator branch February 23, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants