Scan twice before recording a failed scan #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
force-pushed
the
chris/double-scan
branch
from
0569577 to
95e86aa
Compare
ChrisSchinnerl
force-pushed
the
chris/double-scan
branch
from
58e9581 to
4d5a18a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that most of the churn on Arequipa comes from host being offline while other nodes report they are not. To rule out scans being fragile this PR scans twice if necessary.
Ran this on Arequipa and immediately after startup I'm seeing
renterd-arequipa | 2024-02-09T13:49:43Z INFO worker.worker worker/worker.go:1430 successfully scanned host ed25519:ec7389996f3cf39fe5073b82d98c65145936863082d6af16a307a6180b750cfc after retryso it seems like it's making things a bit more robust.