Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ObjectsBySlabKey #842

Closed
wants to merge 1 commit into from
Closed

Conversation

peterjan
Copy link
Member

@peterjan peterjan commented Dec 19, 2023

This method is unused and uses rawObjectMetadata, the fewer usages of that raw object hydration the better so I removed it. I suspect it was used at one point in the autopilot but that is no longer the case. Already removed it from the docs.

@peterjan peterjan self-assigned this Dec 19, 2023
Copy link
Member

@ChrisSchinnerl ChrisSchinnerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check what exactly this was used for in the autopilot and whether this is used by the UI for anything?

@peterjan
Copy link
Member Author

It was not used in the UI nor the autopilot. However we were planning on using this method to give a little more information about slab migration failures. I'll create an issue for it instead and close this out.

@peterjan peterjan closed this Dec 20, 2023
@ChrisSchinnerl ChrisSchinnerl deleted the pj/remove-objects-by-slabkey branch July 3, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants