Defrag wallet implicitly and reduce wallet maintenance to 10 outputs #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjan
reviewed
Dec 18, 2023
ChrisSchinnerl
commented
Dec 20, 2023
peterjan
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we've created 1 output per contract we want to form as part of the contract maintenance. That works but is not optimal since a large node with 200 outputs will frequently run into transactions which are too large for the transaction pool when trying to send a greater amount of Siacoins.
Now that we spend unconfirmed outputs when forming contracts, we can get away with fewer outputs. So this PR sets that number to 10 outputs and allows the wallet to grow up to 30 before starting to defrag the outputs the same way
hostddefragments outputs.