Fix out-of-collateral algorithm #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjan
reviewed
Dec 18, 2023
peterjan
reviewed
Dec 18, 2023
peterjan
reviewed
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arequipa kept refreshing a specific contract in a loop because the autopilot considered the contract out-of-collateral but just before refreshing the contract we didn't. So we didn't enforce a minimum on the collateral expected to be in the contract after the refresh.
To fix this I changed the
isOutOfCollateralcheck to be more in line withisOutOfFundsone. Instead of looking at a theoretical amount of funding the contract might have after a refresh, we use the remaining funds in a contract to determine how much storage it is still good for and then expect the amount of remaining collateral to cover 5% of that storage.Only when we refresh the contract, we use the new
renterFundsto determine theminNewCollateralsince increasing therenterFundsmight push a contract over the threshold