PriceTable Cache Fix #792
Merged
PriceTable Cache Fix #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very big mistake here on this line. Essentially we're caching price tables that weren't registered on the host side. Worst cases I've seen is 2h validity periods so that would mean the host is rendered useless for two hours.
I consider this a hotfix, I'll think about ways to improve it. The mistake was to be anal about having RPCPriceTable returning a
hostdbentity... should've just returned it from the start and be safe. The method processing the payment now dictates theExpiryto ensure we'll never hand out "seemingly-valid-price-tables" ever again.