-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use update instead of CreateInBatches in CompleteMultipartUpload #776
Conversation
should we mention #769 here? |
Do you think we need to have the slab order included in the object metadata? |
db04d5a
to
b2ed2eb
Compare
This PR uses an update instead of create now when completing a multipart upload.
That's possible now since we recently added the
object_index
to the slices and we no longer rely on the ID for the insertion order.This also gets rid of the separate
PartialSlabs
field in theobject.Object
since workers won't be able to deduct the right download order. Instead partial slabs are now part of the regular slabs but without any slices.Closes #769