S3 AuthenticationSettings validation #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internal/testing/s3_test.go
Outdated
| for i := range b { | ||
| b[i] = charset[frand.Intn(len(charset))] | ||
| } | ||
| return string(b) |
There was a problem hiding this comment.
If the charset doesn't matter then why not do strings.Repeat("a", length) ?
ChrisSchinnerl
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think something might've gotten mixed up when we added s3 key requirements. AccessKeyIDs should be between 16-128 characters (and are usually 20 in AWS S3) and secret keys are always 40. I'm assuming that's where the 40 came from so I added that assertion and updated the access key id assertions.