-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics: Contract set churn #675
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
force-pushed
the
chris/metrics-dev-2
branch
from
October 16, 2023 14:34
1fd78cd
to
b66b8c4
Compare
ChrisSchinnerl
force-pushed
the
chris/metrics-dev
branch
2 times, most recently
from
October 17, 2023 07:57
fac9ee7
to
2c24c0e
Compare
ChrisSchinnerl
force-pushed
the
chris/metrics-dev-2
branch
from
October 17, 2023 08:08
b66b8c4
to
d5267af
Compare
ChrisSchinnerl
changed the base branch from
chris/metrics-dev
to
chris/metrics
October 18, 2023 07:28
ChrisSchinnerl
force-pushed
the
chris/metrics-dev-2
branch
from
October 18, 2023 08:07
d5267af
to
8afb36f
Compare
peterjan
pushed a commit
that referenced
this pull request
Nov 15, 2023
* stores: add another db dedicated to storing metrics * stores: close metrics db * stores: add indices * stores: add recording and querying of contract set metrics as well as TestContractSetMetrics * bus: fix TestClient * stores: add missing 'size' tags * stores: change datatype to int64 * stores: bigint * stores: metrics.go change ordering * stores: add api types for contract set metrics * stores: address review comments * stores: implement contract set churn metrics * stores: implement performance metrics * stores: implement contract metric recording and querying * bus: hook up contract set churn metrics to bus * testing: add TestRecordContractSetAndChurnMetric * stores: catch uint8 slice for unixTimeMS * stores: change GormDataType from BIGINT to int * stores: use strconv to scan unixTimeMS * stores: use strconv for Scan in unsigned64 * stores: rename Time -> Timestamp * stores: update comment on Value * stores: fix scopeTimeRange * stores: fix TestContractSetMetrics * bus: hook up contract metrics to API * stores: record contract metrics when spending is recorded * stores: fix TestRenewedContract * testing: fix TestUploadDownloadSpending * stores: TestBusRecordedMetrics * testing: fix TestBusRecordedMetrics NDF * Metrics: Contract set churn (#675) * stores: implement contract set churn metrics * stores: fix build * stores: implement performance metrics * stores: fix TestPerformanceMetrics * Metrics: Contract metrics (#679) * stores: implement contract set churn metrics * stores: implement performance metrics * stores: implement contract metric recording and querying * stores: fix contractMetrics query * Metrics: Record contract set churn metrics and contract set metrics (#680) * bus: hook up contract set churn metrics to bus * testing: add TestRecordContractSetAndChurnMetric * stores: catch uint8 slice for unixTimeMS * stores: change GormDataType from BIGINT to int * stores: use strconv to scan unixTimeMS * stores: use strconv for Scan in unsigned64 * stores/autopilot: address review comments * bus/stores: address review comments * stores: fix TestSQLContractStore and TestRenewedContract * testing: fix TestBusRecordedMetrics * Metrics: Update endpoint to use intervals (#720) * bus: update metrics endpoint to use intervals like hostd * stores: add docstring to scopePeriods * testing: fix TestBusRecordedMetrics * stores: fix scopePeriods for MySQL * stores: add Group By to scopePeriods * stores: use SELECt in join * stores: remove select with limit again * stores: change findPeriods to use window function * stores: address review comments * bus: update json tags * bus: fix merge issues * testing: fix TestBusRecordedMetrics * main: specify mysql metrics database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements contract set churn metrics.
Depends on #670