ETags #625
Merged
ETags #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o pj/mime-type
…o pj/mime-type
…o pj/mime-type
…o pj/mime-type
…o pj/mime-type
…o pj/serve-content
Closed
…o pj/serve-content
…o pj/serve-content
…o pj/serve-content
ChrisSchinnerl
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets ETags on the response headers and changes our serve endpoint to make use of
http.ServeContent. That's nice because it'll handle caching related request headers and return 304 Not Modified when possible, allowing clients to cache our content locally.I tested this manually but I thought it could be fun to play-test this PR on the nextcloud setup you have maybe? That should highlight any issues pretty fast I guess.