Add support for multipart uploads #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
force-pushed
the
chris/multipart-uploads
branch
from
1c795ca to
6865776
Compare
ChrisSchinnerl
commented
Sep 18, 2023
peterjan
reviewed
Sep 19, 2023
| return err | ||
| } | ||
|
|
||
| // TODO: f/u with support for 'prefix', 'keyMarker' and 'uploadIDMarker' |
There was a problem hiding this comment.
It's on my list of things to f/u with.
peterjan
reviewed
Sep 19, 2023
peterjan
reviewed
Sep 19, 2023
| MultipartListUploadsResponse struct { | ||
| Uploads []MultipartListUploadItem `json:"uploads"` | ||
| } | ||
| MultipartListUploadItem struct { |
There was a problem hiding this comment.
So it could be in MultipartListUploadsResponse but I didn't add it since we don't need it to satisfy the corresponding S3 endpoint. We can just take the bucket from the request.
peterjan
reviewed
Sep 19, 2023
peterjan
reviewed
Sep 19, 2023
peterjan
reviewed
Sep 19, 2023
|
So etags are great, usually they're used to be able to return a 304 not modified response right (so the client can use its cached version), maybe we should extend |
peterjan
reviewed
Sep 19, 2023
| return n, err | ||
| } | ||
|
|
||
| func (e *hashReader) Etag() string { |
peterjan
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for multipart uploads to the S3 API without storing the whole upload in memory.
NOTE: Migration code will be added and tested upon approval in case things still change.
Limitations
disablePreshardingEncryptionhas to be 'true' when uploading a part. This will be fixed asap in a f/u with appropriate testing.