-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test): fix v2 related NDFs in test suite #1758
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
changed the title
Update require height for v2 tests
chore(test): update require height for v2 tests
Dec 18, 2024
ChrisSchinnerl
force-pushed
the
chris/update-test-require-height
branch
from
December 18, 2024 11:04
6c26831
to
fba07f8
Compare
ChrisSchinnerl
force-pushed
the
chris/update-test-require-height
branch
from
December 18, 2024 12:21
b56b9d2
to
176dcec
Compare
ChrisSchinnerl
changed the title
chore(test): update require height for v2 tests
chore(test): fix v2 related NDFs in test suite
Dec 18, 2024
ChrisSchinnerl
force-pushed
the
chris/update-test-require-height
branch
7 times, most recently
from
December 18, 2024 14:02
551bfcc
to
511c4c7
Compare
ChrisSchinnerl
force-pushed
the
chris/update-test-require-height
branch
from
December 18, 2024 14:46
3638b3c
to
1b36054
Compare
ChrisSchinnerl
force-pushed
the
chris/update-test-require-height
branch
from
December 18, 2024 14:47
1b36054
to
168657d
Compare
…dation/renterd into chris/update-test-require-height
peterjan
reviewed
Dec 19, 2024
peterjan
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all the NDFs apart from the panic which we will need to fix in
coreutils
.