Extend OpenAPI docs for bus API
#1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I'd paste the spec into https://editor.swagger.io and go over the examples it generates. There are a bunch of places where the example says "string" which I think never needs to be the case cause we are very specific about what can be returned.
| arbitraryData: | ||
| type: array | ||
| items: | ||
| type: string |
There was a problem hiding this comment.
I'd add a pattern here if it is hex
There was a problem hiding this comment.
It's not hex encoded, it's really arbitrary data.
ChrisSchinnerl
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Routes added:
consensus/contracts/contract/hosts/metric/multipart/object/params/slabbuffers/sectors/settings/slabs/state/syncer/system/txpool/upload/wallet/webhooks