-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: Add integration test for network transition from v1 to v2 #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
changed the title
e2e: add TestV1ToV2Transition
e2e: Add integration test for network transition from v1 to v2
Dec 12, 2024
ChrisSchinnerl
force-pushed
the
chris/transition-test
branch
from
December 13, 2024 13:13
763cde7
to
e325ac9
Compare
… are on right hosts
ChrisSchinnerl
force-pushed
the
chris/transition-test
branch
from
December 13, 2024 13:14
e325ac9
to
c20ce92
Compare
ChrisSchinnerl
force-pushed
the
chris/transition-test
branch
from
December 13, 2024 14:32
cfffa62
to
aae5a28
Compare
ChrisSchinnerl
force-pushed
the
chris/transition-test
branch
from
December 13, 2024 15:11
e4d0b27
to
8ba3f65
Compare
ChrisSchinnerl
force-pushed
the
chris/transition-test
branch
from
December 13, 2024 15:36
9ec595c
to
73ce2b2
Compare
peterjan
reviewed
Dec 17, 2024
peterjan
reviewed
Dec 17, 2024
peterjan
reviewed
Dec 17, 2024
peterjan
reviewed
Dec 17, 2024
peterjan
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failing but looking pretty good to me overall 💪
ChrisSchinnerl
force-pushed
the
chris/transition-test
branch
from
December 17, 2024 10:42
d4b31f4
to
8d127ff
Compare
peterjan
reviewed
Dec 18, 2024
peterjan
reviewed
Dec 18, 2024
peterjan
previously approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1546