Improve sector upload estimate tracking #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjan
force-pushed
the
pj/test-track-sector-upload
branch
from
7f4a075 to
f2c598b
Compare
peterjan
changed the title
peterjan
force-pushed
the
pj/test-track-sector-upload
branch
from
2d35b09 to
b2b978e
Compare
peterjan
force-pushed
the
pj/test-track-sector-upload
branch
from
b2b978e to
47a364d
Compare
peterjan
commented
Apr 29, 2024
peterjan
force-pushed
the
pj/test-track-sector-upload
branch
from
d5a2db3 to
1a39a4e
Compare
ChrisSchinnerl
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that Chris 's hunch was right and that we are not tracking sector upload estimates at times we should be, even worse we currently don't track anything at times we should be penalising the host for being slow. I added explicit logging for when we penalise a host for being (super) slow, so going to follow this up on my node to be sure.
Overall I thought it was a little tricky to come up with a good way to fix it and to write a solid unit and/or integration test for it. If we really want to check the exact errors we would need an integration test but that would involve a level of orchestration we are currently not capable of doing from an integration test. The unit test I came up with is not exactly what I was hoping for but it does cover all branches.
Closes #1167