Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional MinProtocolVersion setting to autopilot config #1143

Merged
merged 6 commits into from
Apr 15, 2024

Conversation

ChrisSchinnerl
Copy link
Member

@ChrisSchinnerl ChrisSchinnerl commented Mar 28, 2024

That allows users to define their own minimum protocol version. e.g. users might want to only use 1.5.9+ hosts so they can enforce that even though renterds minimum is set to 1.5.9.

If no version is set, only the global MinProtocolVersion is applied.

Related to #1141

@ChrisSchinnerl ChrisSchinnerl force-pushed the chris/min-version branch 2 times, most recently from 332dc5c to 5067545 Compare March 28, 2024 14:02
@ChrisSchinnerl ChrisSchinnerl requested a review from peterjan March 28, 2024 14:35
@ChrisSchinnerl ChrisSchinnerl marked this pull request as ready for review March 28, 2024 14:35
@ChrisSchinnerl ChrisSchinnerl self-assigned this Mar 28, 2024
@ChrisSchinnerl
Copy link
Member Author

@alexfreska For the UI it's probably best to check if the autopilot is configured first. If it isn't, we can default to 1.6.0 unless the user sets a different value. If it is, we set the value to the empty string to not enforce a limit beyond the one the backend already enforces implicitly.

The "suggested" value we display to the user should probably be 1.6.0 too. To indicate that it's in the user's best interest to not use older hosts.

Regardless of the value set by the user, the backend won't use anything older than 1.5.9 but we can't implicitly have the backend set this value since it might cause data loss in the current landscape of hosts.

autopilot/hostscore.go Outdated Show resolved Hide resolved
autopilot/hostscore.go Outdated Show resolved Hide resolved
autopilot/hostscore.go Outdated Show resolved Hide resolved
@ChrisSchinnerl ChrisSchinnerl requested a review from peterjan April 4, 2024 08:58
@ChrisSchinnerl ChrisSchinnerl merged commit e3c1233 into dev Apr 15, 2024
8 checks passed
@ChrisSchinnerl ChrisSchinnerl deleted the chris/min-version branch April 15, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants